Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP ^8.2 and Drush 13 dev to allow Tugboat builds #607

Closed
wants to merge 7 commits into from

Conversation

beto-aveiga
Copy link
Collaborator

@beto-aveiga beto-aveiga commented Jul 11, 2024

  • Updates to PHP 8.2 (at least)
  • Updates to drush/drush 13 (dev)

Related to: #605

@github-actions github-actions bot had a problem deploying to pantheon-pr-607 July 11, 2024 14:22 Failure
@github-actions github-actions bot had a problem deploying to pantheon-pr-607 July 11, 2024 15:00 Failure
@beto-aveiga beto-aveiga changed the title Not merge test tugboat PHP ^8.2 and Drush 13 dev to allow Tugboat builds Jul 11, 2024
@beto-aveiga beto-aveiga marked this pull request as ready for review July 11, 2024 17:33
@@ -10,10 +10,10 @@
"psr-4": {"Lullabot\\Drainpipe\\Tests\\Functional\\": "tests/src/functional/"}
},
"require": {
"php": "^8.1",
"php": "^8.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like PHP 8.1 is still supported until Jan. 1 2026.

Wouldn't ^8.1 still allow PHP 8.2 to be installed?
Why do we need to force a minimum of PHP 8.2?

"ext-json": "*",
"composer-plugin-api": "^2.0",
"drush/drush": "^11|^12|^13",
"drush/drush": "13.x-dev",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need Drainpipe to support 11, 12, and 13.
We can't force all projects to dev version of 13. But I understand we needed to do that to get Tugboat's drush sql-sanitize to work because of https://www.drupal.org/node/3431286

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deviantintegral @justafish knowing that we can't (nor do we want to) force everyone to PHP 8.2 and a dev release of Drush 13, what are our options here to unblock pull requests that are only failing on Tugboat builds with this sessions table error?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should reach out to Moshe and ask about rolling a Drush 12 point release. Since this breaks for drupal 10.3 (and not 11) I think getting that out is the best thing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deviantintegral to unblock our recent PRs would it be okay to pin the Drupal version while we wait for Drush to create new releases? #608

@mrdavidburns
Copy link
Member

Closing in favor of #608

@mrdavidburns mrdavidburns deleted the NOT-MERGE--test-tugboat branch July 16, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants