This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
feat(account): improve the empty state #4897
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution.
Why /generate-screenshots ?If your PR contains UI related changes, |
|
/generate-screenshots |
qd-qd
force-pushed
the
feat/account-action-empty-state
branch
from
fc393df
to
0d7b219
Compare
Coverage report
Test suite run success1 tests passing in 1 suite.Report generated by 🧪jest coverage report action from 0d49a28 |
ofreyssinet-ledger
approved these changes
Apr 6, 2022
Until now, the header in the account page for an empty account (no txs) wasn't rendered. Because of this, walletconnect button wasn't rendered, you needed some tokens to see it appears. This commit fixes this, from now, walletconnect button and receive/buy buttons would be rendered for any empty accounts. As it is not required to own tokens to use walletconnect, this modification makes sense to me. Regarding the receive/buy buttons, I think it's better to have them always available, even for empty accounts (we missed a business opportunity by hidding the buy button in this case).
qd-qd
force-pushed
the
feat/account-action-empty-state
branch
from
0d7b219
to
0d49a28
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦒 Context (issues, jira)
Until now, the header in the account page for an empty account (no txs) wasn't
rendered. Because of this, walletconnect button wasn't rendered, you needed
some tokens to see it appears. This commit fixes this, from now, walletconnect
button and receive/buy buttons would be rendered for any empty accounts.
As it is not required to own tokens to use walletconnect, this modification makes
sense to me. Regarding the receive/buy buttons, I think it's better to have them
always available, even for empty accounts (we missed a business opportunity by
hidding the buy button in this case).
💻 Description / Demo (image or video)
Before
After
🖤 Expectations to reach
PR must pass CI, rebase develop if conflicts. Thanks!