This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(account): improve the empty state
Until now, the header in the account page for an empty account (no txs) wasn't rendered. Because of this, walletconnect button wasn't rendered, you needed some tokens to see it appears. This commit fixes this, from now, walletconnect button and receive/buy buttons would be rendered for any empty accounts. As it is not required to own tokens to use walletconnect, this modification makes sense to me. Regarding the receive/buy buttons, I think it's better to have them always available, even for empty accounts (we missed a business opportunity by hidding the buy button in this case).
- Loading branch information
0d49a28
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint outputs ✅
Tests outputs ✅
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating
PASS src/generate-cryptoassets-md.test.js
Test Suites: 1 skipped, 1 passed, 1 of 2 total
Tests: 5 skipped, 1 passed, 6 total
Snapshots: 0 total
Time: 2.822 s
Test results written to: report.json
Diff output ❌
windows
| confirm-exchange-actual | confirm-exchange-diff | confirm-exchange-expected |
| | | |