Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use the DpexTargetContext inside dpjit #1027

Closed
wants to merge 4 commits into from

Conversation

diptorupd
Copy link
Collaborator

@diptorupd diptorupd commented May 4, 2023

  • Have you provided a meaningful PR description?

The PR is a draft for the set of changes to ensure that numba_dpex.dpjit uses its own target that is isolated from Numba's
CPUTarget. The goal of the PR is to ensure numba-dpex does not have unintended side effects on Numba, and also free numba-dpex to implement custom dispatch, caching, function registry support.

  • Have you added a test, reproducer or referred to an issue with a reproducer?

  • Have you tested your changes locally for CPU and GPU devices?
    As yet minimally.

  • Have you made sure that new changes do not introduce compiler warnings?

  • If this PR is a work in progress, are you filing the PR as a draft?'

Fixes #1024

@diptorupd diptorupd marked this pull request as draft May 4, 2023 04:16
@diptorupd
Copy link
Collaborator Author

FYA @chudur-budur the changes in my PR will impact your SyclQueue work. I will merge my changes only after you are done.

@diptorupd diptorupd changed the title Use the DpexTargetContext inside dpjit [WIP] Use the DpexTargetContext inside dpjit May 5, 2023
@diptorupd diptorupd changed the base branch from main to feature/remove_numpy_array_kernelargs May 20, 2023 19:08
@github-actions
Copy link
Contributor

Documentation preview: show.

Base automatically changed from feature/remove_numpy_array_kernelargs to main May 22, 2023 20:40
@diptorupd diptorupd force-pushed the feature/DpexTargetContext branch 2 times, most recently from 23aaf11 to 407ee35 Compare May 23, 2023 04:11
@diptorupd diptorupd force-pushed the feature/DpexTargetContext branch 3 times, most recently from 4af7777 to 2219ad0 Compare May 31, 2023 15:47
    - Moved all dpnp overload and intrinsic functions
      into the dpex target.
    - The dpjit decorator now uses the DpexTargetContext
      instead of the CPUTarget.
    - All initialization of the DpjitDispatcher now do a
      target_override to "dpex".
    - The PreParfor pass can invoke NumPy overloads such as
      numpy.dtype. The changes here introduced a dpex-specific
      PreParfor pass that runs the upstream pass after doing a
      target override to the dpex target.
@diptorupd diptorupd deleted the feature/DpexTargetContext branch January 8, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using DpexTargetContext for dpjit, dpnp overloads, and dpnp ufuncs
1 participant