Numba-mlir integration #1130
Closed
Numba-mlir integration #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptorupd
reviewed
Sep 14, 2023
| @@ -155,6 +155,7 @@ def dpjit(*args, **kws): | |||
| kws.update({"nopython": True}) | |||
| kws.update({"parallel": True}) | |||
| kws.update({"pipeline_class": DpjitCompiler}) | |||
| kws.update({"_target": "dpex"}) | |||
There was a problem hiding this comment.
I ran into a problem with this change previously (see the FIXME note few lines below). The dpnp overloads are right now added to the CPUTarget and changing dpjit to use DpexTarget makes numba not locate the dpnp overloads.
#1027 needs to be completed first before we can do the change.
Merged
|
Not being considered at this point, we will revive again if we consider integration in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use_mliroption to decorator with proper target options supportNUMBA_MLIR_LOG_GPU_RUNTIME_CALLS=1to check if numba-mlir gpu runtime was actually invoked