Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Drop noenc packets if RcvKmState is "secured". #2921

Merged

Conversation

maxsharabayko
Copy link
Collaborator

Previously unencrypted packets were being dropped in case AES-GCM mode was used.
With this change, they are being dropped if the KM connection state is "Secured".
It respects the SRTO_ENFORCED_ENCRYPTION option that allows connections without encryption, in which case the RCV KM state would be "Unsecured".

@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Apr 9, 2024
@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Apr 9, 2024
Updated pktRcvUndecrypted description.
@maxsharabayko maxsharabayko marked this pull request as ready for review April 11, 2024 08:14
@maxsharabayko maxsharabayko merged commit 83077aa into Haivision:master Apr 11, 2024
12 checks passed
@maxsharabayko maxsharabayko deleted the hotfix/km_secured_drop_noenc branch April 11, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant