Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom release SRT v1.5.3a #2946

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Apr 26, 2024

This is a custom release of SRT v1.5.3 with some bug fixes that will be used in certain solutions until SRT v1.5.4 is released.

The List of PRs Included

@maxsharabayko maxsharabayko marked this pull request as draft April 26, 2024 12:53
@maxsharabayko maxsharabayko changed the base branch from master to custom-release/v1.5.3a April 26, 2024 12:54
@maxsharabayko maxsharabayko deleted the branch Haivision:custom-release/v1.5.3a April 26, 2024 12:55
@maxsharabayko maxsharabayko reopened this Apr 26, 2024
@maxsharabayko maxsharabayko changed the title Custom release/v1.5.3a Custom release SRT v1.5.3a Apr 26, 2024
maxsharabayko and others added 20 commits April 26, 2024 15:06
condition in case of dropping upto a sequence number.
…H tag (Haivision#2880).

* Fixed build break due to const use of UniquePtr.
The list of options was unordered, hence the binary search failed to find those options.
Also downgraded some logs from 'note' level to 'debug'.
…).

Valid for a broadcast group member dropping existing packets from the RCV buffer because they were read from another member.

Co-authored-by: Sektor van Skijlen <[email protected]>
Also renamed CUDT::m_bTsbPdAckWakeup.
Added some function to the CRcvBuffer.

Co-authored-by: Sektor van Skijlen <[email protected]>
Updated pktRcvUndecrypted description.
@maxsharabayko maxsharabayko added the [build] Area: Changes in build files label Apr 26, 2024
@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 67.08%. Comparing base (09f35c0) to head (5fd96c3).

Files Patch % Lines
srtcore/core.cpp 84.09% 7 Missing ⚠️
srtcore/group.cpp 56.25% 7 Missing ⚠️
srtcore/buffer_rcv.h 0.00% 4 Missing ⚠️
srtcore/buffer_rcv.cpp 75.00% 3 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           custom-release/v1.5.3a    #2946      +/-   ##
==========================================================
- Coverage                   67.20%   67.08%   -0.13%     
==========================================================
  Files                         102      102              
  Lines                       20269    20305      +36     
==========================================================
- Hits                        13622    13621       -1     
- Misses                       6647     6684      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxsharabayko maxsharabayko marked this pull request as ready for review April 29, 2024 08:52
@maxsharabayko maxsharabayko merged commit 39b5651 into Haivision:custom-release/v1.5.3a Apr 29, 2024
3 checks passed
@maxsharabayko maxsharabayko deleted the custom-release/v1.5.3a branch April 29, 2024 08:53
@maxsharabayko maxsharabayko restored the custom-release/v1.5.3a branch April 29, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[build] Area: Changes in build files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants