Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix date entry to allow time/date or date/time ordering #37

Open
wants to merge 5 commits into
base: main-dev
Choose a base branch
from
Open

Fix date entry to allow time/date or date/time ordering #37

wants to merge 5 commits into from

Commits on Mar 31, 2019

  1. Fix typo in private-settings example

    @jaretcantu
    jaretcantu committed Mar 31, 2019
    Configuration menu
    Copy the full SHA
    f617646 View commit details
    Browse the repository at this point in the history

  2. Combine common code in time type

    @jaretcantu
    jaretcantu committed Mar 31, 2019
    Configuration menu
    Copy the full SHA
    512ea8d View commit details
    Browse the repository at this point in the history

  3. Allow time-date pairs to be entered in any order

    @jaretcantu
    jaretcantu committed Mar 31, 2019
    Configuration menu
    Copy the full SHA
    1fbbd9b View commit details
    Browse the repository at this point in the history

  4. Assume all times of three digits or more are absolute 

    Since the current maximum egg timer is sixty minutes, and it is
unlikely for any time to be set for greater than 100 minutes
relative to the current time, assume that all three digit times
are the "hour:minute" format without the colon.
    @jaretcantu
    jaretcantu committed Mar 31, 2019
    Configuration menu
    Copy the full SHA
    a21331b View commit details
    Browse the repository at this point in the history

  5. Limit absolute times to reasonable daylight hours 

    In the case of EX raids, catch the case where an unqualified hour
is used as the start time (e.g., 1:00) and the start time is set
for the middle of the night (1:00am).  This can be done by setting
times for which raid eggs are known to be active.
    @jaretcantu
    jaretcantu committed Mar 31, 2019
    Configuration menu
    Copy the full SHA
    ebe5311 View commit details
    Browse the repository at this point in the history