Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix date entry to allow time/date or date/time ordering #37

Open
wants to merge 5 commits into
base: main-dev
Choose a base branch
from
Open

Fix date entry to allow time/date or date/time ordering #37

wants to merge 5 commits into from

Conversation

jaretcantu
Copy link

  • Allow time or date to be entered first for time commands
  • Always assume three-digit entries to be an absolute time
  • Limit absolute times to reasonable hours so that EX raids are no longer accidentally posted to 1am

@jaretcantu
Fix typo in private-settings example
f617646
@jaretcantu
Combine common code in time type
512ea8d
@jaretcantu
Allow time-date pairs to be entered in any order
1fbbd9b
@jaretcantu
Assume all times of three digits or more are absolute
a21331b 
Since the current maximum egg timer is sixty minutes, and it is
unlikely for any time to be set for greater than 100 minutes
relative to the current time, assume that all three digit times
are the "hour:minute" format without the colon.
@jaretcantu
Limit absolute times to reasonable daylight hours
ebe5311 
In the case of EX raids, catch the case where an unqualified hour
is used as the start time (e.g., 1:00) and the start time is set
for the middle of the night (1:00am).  This can be done by setting
times for which raid eggs are known to be active.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jaretcantu