master: Resolve blank map when running compiled with latest cordova-android (which uses AGP 4.1.3) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably the bug of the Google Maps SDK for Android v3 beta
…s upgraded AGP to 4.1.3
GitToTheHub
changed the title
GitToTheHub
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mapsplugin#2871
From AGP 4.1.+ assert keyword/statements are enabled by the compile through code rewrite.
Which is causing PluginMap to fail
The issue is caused by PluginMap being initialised 2 times. The 2nd time it is initialised, CordovaPlugin.privateInitialize has assert to prevent this.
This PR removes initialising the PluginMap in CordovaGoogleMaps.getMap, because when it is added to PluginManager it will be initialised then.
NOTE
Although the relevant code in PluginManager and CordovaPlugin has not been changed for many years.
The plugin's codebase works for older cordova-android versions because they use older AGP.
In these older versions, assert keyword/statement do nothing