-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hydrometeors #422
base: develop
Are you sure you want to change the base?
Add hydrometeors #422
Changes from all commits
5e7ebbc
365ac55
71bcc0b
82080b1
92a88c9
60151ee
ec72d72
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did you accidentally changed the file permissions here? |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did you accidentally changed the file permissions here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok - 1st to the file permissions: not accidental - I don't see any reason for yaml files to be executable files, unless I am missing something, am I? |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. permission |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
variable change: | ||
variable change name: Model2GeoVaLs | ||
hydrometeor effective radii method: gsi |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. permission |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. permission |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. permission |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. permission |
Original file line number | Diff line number | Diff line change | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -12,6 +12,9 @@ background: | |||||||||||||||
TASKFILLbackground_ensemble | ||||||||||||||||
|
||||||||||||||||
observations: | ||||||||||||||||
get values: | ||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When you put anything in the OOPS part of SWELL this will impact the marine side as well if it's a generic application. So for this, we don't have a corresponding However when I searched for this swell/src/swell/tasks/run_jedi_ufo_tests_executable.py Lines 87 to 93 in 2b0f03b
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As I say below, I personally see no reason why an entry that's used in the Var should not be present in the UFO test; that makes the UFO test inconsistent w/ the Var ... but also, as I say below, I don't particularly care too much about what's being done in these tests. What I care about is for the Var opts/settings to come out correctly - and believe they do .... as look at the final yaml file in my Var runs. |
||||||||||||||||
TASKFILLgetvalues | ||||||||||||||||
|
||||||||||||||||
observers: | ||||||||||||||||
SPECIALobservations | ||||||||||||||||
|
||||||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,5 +10,7 @@ state: | |
TASKFILLbackground | ||
|
||
observations: | ||
get values: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same above^ There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the correct way of handling this? I am completely surprised and puzzled as to why the UFO tasks are removing the "get values" entries ... but then again, I don't care too much about those tests. So the important thing for me is to have "get values" properly appear in the Var cases ... which as far as I know they do. Now, I didn't think of that upsetting the marine apps ... so I agree that something else would need to be done to avoid that - perhaps as you say, implementing an empty "get values" |
||
TASKFILLgetvalues | ||
observers: | ||
SPECIALobservations |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,8 @@ cost function: | |
background error: | ||
TASKFILLbackground_error | ||
observations: | ||
get values: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same above^ |
||
TASKFILLgetvalues | ||
observers: | ||
SPECIALobservations | ||
variational: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
permission issue