-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hydrometeors #422
base: develop
Are you sure you want to change the base?
Add hydrometeors #422
Conversation
The PRs from JEDI mentioned above have been merged. I believe the changes here could now make it into SWELL |
@rtodling Can you set the environment |
This will be on-hold until a JEDI build post ~September 20th. |
@Dooruk All tests seem to have passed for this - can we take this in? If not, can we chat? |
Did you run t1tests? I will fire it up in github actions now |
I was looking in the doc how as I user I can fire up the tier-1 test ... but it's not quite clear to me. |
Doesn't this require the new JEDI build by the way? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So overall, there are issues regarding get_values
and file permissions were changed. These changes are breaking ocean 3dvar and hofx.
@@ -12,6 +12,9 @@ background: | |||
TASKFILLbackground_ensemble | |||
|
|||
observations: | |||
get values: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you put anything in the OOPS part of SWELL this will impact the marine side as well if it's a generic application. So for this, we don't have a corresponding get_values.yaml
on the geos_ocean
side and 3dvar
is complaining. One option is that I can create an dummy get_values.yaml
which is fine.
However when I searched for this get values
key in the SWELL source code I see sections that modifies that behavior, see below, so we have to be careful with this:
swell/src/swell/tasks/run_jedi_ufo_tests_executable.py
Lines 87 to 93 in 2b0f03b
# Remove the LinObsOperator and Insert the GeoVaLs section | |
# --------------------------------------------------------- | |
# Loop over the observations | |
for index in range(len(observations)): | |
# Remove GetValues if present | |
if 'get values' in jedi_config_dict['observations'][index]: | |
del jedi_config_dict['observations'][index]['get values'] |
@@ -10,5 +10,7 @@ state: | |||
TASKFILLbackground | |||
|
|||
observations: | |||
get values: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same above^
@@ -13,6 +13,8 @@ cost function: | |||
background error: | |||
TASKFILLbackground_error | |||
observations: | |||
get values: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same above^
@@ -18,6 +18,8 @@ cost function: | |||
background error: | |||
TASKFILLbackground_error | |||
observations: | |||
get values: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same above^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you accidentally changed the file permissions here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
permission
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
permission
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
permission
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
permission
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
permission
Description
This adds hydrometeors and changes to the linear obs operators necessary to account for sensitivity of all-sky MW to such fields.
Dependencies
Impact
Enhanced features and corrections and consistency w/ GSI
Issues
[#418] this is associated w/ the issue marked here.
Required Change in Static Files
This will require a change to the cli_* and hyb_* gsibec 'nml' : all qr/qs references in these files must be uncommented.