fixes #199 Bugfix/tclune/#199 hflux fix 3rd try

[tclune]

See PR #1202 for more details

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Trivial change (affects only documentation or cleanup)

Checklist:

• I have tested this change with a run of GEOSgcm (if non-trivial)
• I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
• I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

[tclune]

@mathomp4 @sdeastham

This is the new PR

[mathomp4]

Adding a blocker until I can test on Discover.

[mathomp4]

I have shown this is zero-diff. So I'll unblock. (Though @atrayano has questions, so it'll still block...)

ETA: I mean to say a simple AMIP C24 run is zero-diff in state and history. Not sure if this could be triggered some other way.

[tclune]

@lizziel I have added the tiny bit of logic that should now generate a semi-meaningful error if HFlux regridding is requested an the grids/decomposition are incompatible.

Untested. 90% probability it at least compiles.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days, it will be closed. You can add the "long term" tag to prevent the Stale bot from closing this issue.

[mathomp4]

I'm going to mark this longterm until @sdeastham can test and give a yea or nay.

Also, I think only @tclune can fix the conflict in base/MAPL_SphericalGeometry.F90 as it's beyond me!

[mathomp4]

Well, I can definitely say that if you don't enable this, the model is zero-diff. I did try to enable it but then history exploded which was its way of saying "You don't know what you are doing Matt". A consult with @bena-nasa confirmed that 😄

[tclune]

Sigh. OK - hopefully I can work on this at some point this week.

[tclune]

OK branch "2nd try" had the corner stuff. And had the better error message that @lizziel had requested. So now I'm struggling to remember why there even is a "3rd try" branch??? That's the problem with letting these go on so long. I'll take a look at the diffs, but may well just close this PR and start with the other ...

[tclune]

@bena-nasa Please check my corrected logic for getting grid corners. Thanks.

[mathomp4]

Due to traffic on #3093 I've updated this PR to develop in case @tclune decides it's time to pull it in.