Horizontal flux regridding bug fix #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fluxes need to be multiplied by edge length for correct treatment. Signed-off-by: Lizzie Lundgren <[email protected]>
4 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in selected updates in GEOS-ESM#2056 to correct a bug in the horizontal flux regridder. Fluxes need to be multiplied by edge length for correct treatment.
Horizontal flux regridding only occurs for mass flux input data. This is therefore a no diff update for GEOS-Chem benchmarks.
See GCHP GitHub issue geoschem/GCHP#377 for more information.