Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update high-res configuration #65

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

sanAkel
Copy link
Collaborator

@sanAkel sanAkel commented Feb 21, 2024

This PR:

  1. Gets rid of commented lines.
  2. Turns off known buggy switches.
  3. Turns on VERTEX_SHEAR (requested by @Dooruk and suggested by @travissluka).
  4. Turns off 2018 answers.

Does not impact answers with MOM5 ocean model.

These changes will cause answers to differ (@mathomp4 please note for testing at this resolution; we already have DEFAULT_2018_ANSWERS = False for coarse-res configuration that is used for testing), for the better!

@sanAkel sanAkel added enhancement New feature or request bugfix Fixes bugs labels Feb 21, 2024
@sanAkel sanAkel self-assigned this Feb 21, 2024
@sanAkel sanAkel marked this pull request as ready for review February 21, 2024 22:18
@sanAkel sanAkel requested a review from a team as a code owner February 21, 2024 22:18
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement, bugfix

5 similar comments
Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement, bugfix

Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement, bugfix

Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement, bugfix

Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement, bugfix

Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: enhancement, bugfix

@sanAkel sanAkel added the Non 0-diff The changes in this pull request are non-zero-diff label Feb 21, 2024
@sanAkel sanAkel merged commit 620a8cc into develop Feb 22, 2024
11 checks passed
@sanAkel sanAkel deleted the feature/sanAkel/update_highRes_config branch February 22, 2024 17:36
@Dooruk
Copy link

Dooruk commented Feb 26, 2024

Thank you @sanAkel for making this update. I see the checkerboard pattern disappear with the new option.

@sanAkel
Copy link
Collaborator Author

sanAkel commented Feb 26, 2024

Thank you @sanAkel for making this update. I see the checkerboard pattern disappear with the new option.

For sake of bookkeeping, @Dooruk, would you please upload that plot? Showing that pattern disappear? Thanks!

@Dooruk
Copy link

Dooruk commented Feb 26, 2024

For sake of bookkeeping, @Dooruk, would you please upload that plot? Showing that pattern disappear? Thanks!

Sure, top one is without the VERTEX_SHEAR option turned on. Also, thanks @travissluka for finding this issue!

compare

@sanAkel
Copy link
Collaborator Author

sanAkel commented Feb 26, 2024

Thanks a lot!

@Dooruk
Copy link

Dooruk commented Feb 29, 2024

@sanAkel, The override is missing #override RESTART_CONTROL = 2 which impacts RECORD_FREQUENCY checkpoint dumps. I don't want to create a new issue for it but that is needed either in MOM_input or MOM_override.

Essentially, RECORD_FREQUENCY option is not creating MOM6 checkpoint files properly. MOM6 restarts keep getting overwritten:

Screenshot 2024-02-29 at 2 09 26 PM

@sanAkel
Copy link
Collaborator Author

sanAkel commented Mar 1, 2024

@sanAkel, The override is missing #override RESTART_CONTROL = 2 which impacts RECORD_FREQUENCY checkpoint dumps. I don't want to create a new issue for it but that is needed either in MOM_input or MOM_override.

Essentially, RECORD_FREQUENCY option is not creating MOM6 checkpoint files properly. MOM6 restarts keep getting overwritten:

Screenshot 2024-02-29 at 2 09 26 PM

@Dooruk will you please add that yourself- in your own version of MOM_override?

I checked previous versions of MOM_input and MOM_override for RESTART_CONTROL, they had default (=1) too.
If I recall correct, you either got that =2 from me offline (or from maybe from someone)? Because clearly previous versions (in this repo) did not have anything but default value.

When we run the model (only) without an assimilation or need for it, we do not want restarts piling up- long runs will exhaust the disk space. That's not your case with short runs. We need to create another MOM_override for assimilation, so please gather this and others you might want and we'll make a new config next time. Ok?

@Dooruk
Copy link

Dooruk commented Mar 1, 2024

@Dooruk will you please add that yourself- in your own version of MOM_override?

Yeah, what you say makes sense, all good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes bugs enhancement New feature or request Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants