-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] データクラスの変数名とJSONキー名の統一 #106
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c909dee
create Mypage Dataclass
yuhei-yama e9166ef
fix data class key name
yuhei-yama 1db6c72
apply new key variable
yuhei-yama cf3ee7c
apply Work repository
yuhei-yama 6b6ce50
fix implementation
yuhei-yama 660442a
apply new key variable
yuhei-yama 101f68b
[fix] data class WorkDataList
yuhei-yama c362cfe
[fix] WorkDataList
yuhei-yama b850514
[fix] data class WorkDetails
yuhei-yama fb5c50e
[fix] data class MyPageData
yuhei-yama 3b53a4d
[fix] add KDoc comment
yuhei-yama dfa1873
[fix] AuthData param
yuhei-yama 2d2eb02
[fix] SignupData param
yuhei-yama ab05fe7
[fix] use data class
yuhei-yama File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
app/src/main/java/com/example/funcy_portfolio_android/model/data/AuthData.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
app/src/main/java/com/example/funcy_portfolio_android/model/data/MyPageData.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
package com.example.funcy_portfolio_android.model.data | ||
|
||
/** | ||
* マイページ (mypage) のデータクラス | ||
* @param works: 中身はWorkDataList.ktを参照してください | ||
*/ | ||
data class MyPageData( | ||
val icon: String, | ||
val header: String, | ||
val user_description: String, | ||
val sns: List<String>, | ||
val group: List<String>, | ||
val skills: List<String>, | ||
val displayName: String, | ||
val works: WorkDataList | ||
) |
13 changes: 8 additions & 5 deletions
13
app/src/main/java/com/example/funcy_portfolio_android/model/data/SignupData.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,15 @@ | ||
package com.example.funcy_portfolio_android.model.data | ||
|
||
/** | ||
* サインアップ(ユーザ情報登録) (signup) のデータクラス | ||
*/ | ||
data class SignupData( | ||
val icon: String, | ||
val familyName: String, | ||
val course: String, | ||
val displayName: String, | ||
val firstName: String, | ||
val grade: String, | ||
val icon: String, | ||
val mail: String, | ||
val password: String | ||
val password: String, | ||
val grade: String, | ||
val course: String, | ||
val displayName: String | ||
) |
15 changes: 13 additions & 2 deletions
15
app/src/main/java/com/example/funcy_portfolio_android/model/data/WorkDataList.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,18 @@ | ||
package com.example.funcy_portfolio_android.model.data | ||
|
||
/** | ||
* 作品一覧画面 (main) のデータクラス | ||
*/ | ||
|
||
data class WorkDataList( | ||
val work_id: Int, | ||
val works: List<WorkData> | ||
) | ||
data class WorkData( | ||
val workID: String, | ||
val userID: String, | ||
val user_name: String, | ||
val title: String, | ||
val images: String | ||
val thumbnail: String, | ||
val description: String, | ||
val icon: String, | ||
) |
15 changes: 11 additions & 4 deletions
15
..._portfolio_android/model/data/WorkData.kt → ...rtfolio_android/model/data/WorkDetails.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,27 @@ | ||
package com.example.funcy_portfolio_android.model.data | ||
|
||
data class WorkData( | ||
/** | ||
* 作品詳細 (workDetail) のデータクラス | ||
*/ | ||
data class WorkDetails( | ||
val title: String, | ||
val description: String, | ||
val thumbnail: String, | ||
val user_icon: String, | ||
val user_name: String, | ||
val userID: String, | ||
val images: List<ImageData>, | ||
val URL: String, | ||
val work_url: String, | ||
val movie_url: String, | ||
val tags: List<TagData>, | ||
val group: String?, | ||
val security: Int, | ||
) | ||
|
||
data class ImageData( | ||
val Image: String | ||
val image: String | ||
) | ||
|
||
data class TagData( | ||
val Tag: String | ||
val tag: String | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
「,」いらない,あっても動くんだっけ?(記憶力なし)