-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] データクラスの変数名とJSONキー名の統一 #106
Conversation
WorkRepositoryにWorkDataおるで |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なんか編集してない部分にコメントできないからここでまとめて!
1←これ関係ないかも
FuncyApiの"auth/code"→"authcode"だな~って思ったけどそこはまた別の話…(メモ感覚)
2
ui/signup/SignupViewModel.kt
SignupDataの中身が古い,順番とかが.
3
ui/authentication/AuthenticationViewModel.kt
AuthData(inputCode.value!!, userId)
順番逆
4
ui/workDetail/WorkDetailViewModel.kt
_workの中身がworkDetailsの形になってるそうな…
※ここを直して動くようになるかは怪しい気がした
5
ui/workRegister/WorkRegisterViewModel.kt
WorkData→WorkDetails(れみねえと同じ指摘になっちゃう)
あと中身が更新前(?)
@@ -1,7 +1,9 @@ | |||
package com.example.funcy_portfolio_android.model.data | |||
|
|||
data class WorkDataList( | |||
val work_id: Int, | |||
val workID: Int, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
userIDとuser_nameたりてないけど,使わないならいいのか
って思ったけど
作品投稿で使いそうです
val images: String | ||
val thumbnail: String, | ||
val description: String, | ||
val icon: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
「,」いらない,あっても動くんだっけ?(記憶力なし)
val movie_url: String, | ||
val tags: List<TagData>, | ||
val group: String?, | ||
val groupID: String?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
プルリクのコメント一部反映しました! コメントの4, 5に関しては,ViewModelだけでなく,Fragmentとか他のファイルにも修正範囲が広がってしまうことから |
対応するissue
概要
意図する動作内容(または変更点)
主な変更は以下です.細かい変更点はファイルを参照
スクリーンショット(UI作成,変更時)
その他