Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable IN operator for comma+space delimited segment values #181

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Jul 5, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

File Coverage
All files 100%

Minimum allowed coverage is 100%

Generated by 🐒 cobertura-action against cd93312

@khvn26 khvn26 marked this pull request as ready for review July 7, 2023 09:16
@novakzaballa
Copy link

Hey @khvn26 , could you please add a description to the PR describing why we need to return false when this AttributeError is thrown? And ideally why other error types are not being handled?

@khvn26
Copy link
Member Author

khvn26 commented Jul 7, 2023

@novakzaballa I removed the extraneus error handling. Could you please take another look?

Copy link

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khvn26 khvn26 merged commit 75d0c18 into main Jul 10, 2023
4 checks passed
@khvn26 khvn26 deleted the fix/in-operator branch July 10, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants