fix: switch IN operator to substring check (#181)

Flagsmith · Jul 10, 2023 · 75d0c18 · 75d0c18
1 parent 2b5bdf2
commit 75d0c18
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/flag_engine/segments/models.py b/flag_engine/segments/models.py
@@ -73,10 +73,7 @@ def evaluate_modulo(self, trait_value: typing.Union[str, int, float, bool]) -> b
         return trait_value % divisor == remainder
 
     def evaluate_in(self, trait_value) -> bool:
-        try:
-            return str(trait_value) in self.value.split(",")
-        except AttributeError:
-            return False
+        return str(trait_value) in (self.value or "")
 
 
 class SegmentRuleModel(BaseModel):

diff --git a/tests/unit/segments/test_segments_models.py b/tests/unit/segments/test_segments_models.py
@@ -64,6 +64,7 @@
         (constants.REGEX, None, r"[a-z]", False),
         (constants.IN, "foo", "", False),
         (constants.IN, "foo", "foo, bar", True),
+        (constants.IN, "bar", "foo, bar", True),
         (constants.IN, "foo", "foo", True),
         (constants.IN, 1, "1,2,3,4", True),
         (constants.IN, 1, "", False),