-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Base implement IScopedNode - phase 1 #2913
Make Base implement IScopedNode - phase 1 #2913
Conversation
…copednode' into spike/make-resource-implement-iscopednode # Conflicts: # src/Hl7.Fhir.Serialization.R4.Tests/RoundtripSignature.cs
…copednode' into spike/make-resource-implement-iscopednode
Serialization is still binary breaking, but not source breaking. It now takes Base instead of Resource |
…igator removed IBaseElementNavigator<T>
src/Hl7.Fhir.Base/Serialization/engine/ElementModelSerializationEngine.cs
Show resolved
Hide resolved
…node # Conflicts: # src/Hl7.Fhir.Base/CompatibilitySuppressions.xml # src/Hl7.Fhir.Base/Model/Base.cs
…copednode' into spike/make-resource-implement-iscopednode
@@ -1,12 +1,334 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids --> | |||
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | |||
<Suppression> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you add info about the breaking changes to the PR, including alternatives that people can use.
src/Hl7.Fhir.Base/Serialization/engine/ElementModelSerializationEngine.cs
Show resolved
Hide resolved
Note: We will investigate to what extent this is breaking after we work our way through the. [TemporarilyChanged] annotations. |
Description
This first step makes POCO's implement ITypedElement. Since we no longer supply an
ITypedElement.Definition
, we had to patch some of the parsers to get all unit-tests back to work. In the end, these changes to the parsers will be reverted, they are just made to be able to continue testing with our extensive set of tests on ITypedElement.Related issues
#2894, #2895
Testing
Tested by making Base.ToTypedElement() point to this implementation. This is temporary.