Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide whether to expose advanced extensions for IFhirSerializationEngine #2951

Open
ewoutkramer opened this issue Oct 23, 2024 · 0 comments

Comments

@ewoutkramer
Copy link
Member

PR #2950 (and #2913 before it) introduced a few extension methods to "reach out" under the limited IFhirSerializationEngine interface to be able to serialize from/to streams and serialize subtrees.

One could argue that IFSerEng was never made for that, and so one should use the lower-level serializer API. However, it is not yet easy to construct such parsers according to our rules for Ostrich/Backwards compat etc, since that is introduced in the higher-level API. So, ideally, one should be able to initialize the BaseXml/JsonPocoSerializers with the same setup as the Engine, so one can then call the lower-level API.

In this case, we can remove these extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant