Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optional fields in EventFilter typespecs #144

Merged
merged 1 commit into from
Oct 14, 2024

Commits on Oct 12, 2024

  1. Support optional fields in EventFilter typespecs

    The current typespec generator emits a dialyzer warning when nil values are set for the indexed topics of an `EventFilter`:
    
    ```elixir
    The function call will not succeed.
    
    Ethers.Contracts.ERC20.EventFilters.transfer(nil, nil)
    
    breaks the contract
    (Ethers.Types.t_address(), Ethers.Types.t_address()) :: Ethers.EventFilter.t()
    ```
    
    This can be fixed by making the arguments nullable for events.
    NduatiK authored Oct 12, 2024
    Configuration menu
    Copy the full SHA
    0eb6636 View commit details
    Browse the repository at this point in the history