Support optional fields in EventFilter typespecs #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current typespec generator emits a dialyzer warning when nil values are set for the indexed topics of an `EventFilter`: ```elixir The function call will not succeed. Ethers.Contracts.ERC20.EventFilters.transfer(nil, nil) breaks the contract (Ethers.Types.t_address(), Ethers.Types.t_address()) :: Ethers.EventFilter.t() ``` This can be fixed by making the arguments nullable for events.
alisinabh
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, thanks for the library alisinabh.
The current typespec generator emits a dialyzer warning when nil values are set for the indexed topics of an
EventFilter:But the indexed topics are nullable.
This PR fixes the typespec by making the arguments nullable for
EventFilters.