Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Enable UDF to handle arbitrary number of Daft series #1984

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

gmweaver
Copy link
Contributor

@gmweaver gmweaver commented Mar 6, 2024

Enables using *args to pass an arbitrary number of Daft series to a UDF.

@gmweaver gmweaver changed the title [FEAT] Enable UDF to hanle arbitrary number of Daft series [FEAT] Enable UDF to handle arbitrary number of Daft series Mar 6, 2024
daft/udf.py Outdated Show resolved Hide resolved
daft/udf.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.71%. Comparing base (5af4ee9) to head (5d00bb0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1984      +/-   ##
==========================================
+ Coverage   84.63%   84.71%   +0.07%     
==========================================
  Files          57       57              
  Lines        6295     6313      +18     
==========================================
+ Hits         5328     5348      +20     
+ Misses        967      965       -2     
Files Coverage Δ
daft/udf.py 94.54% <100.00%> (+1.06%) ⬆️

... and 1 file with indirect coverage changes

@samster25 samster25 added the enhancement New feature or request label Mar 6, 2024
@samster25 samster25 linked an issue Mar 6, 2024 that may be closed by this pull request
@samster25
Copy link
Member

closes #1895

Copy link
Contributor

@jaychia jaychia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks 🔥 🔥 🔥 !!

We should also update the docs for the @udf decorator to show an example of this in action.

@samster25 samster25 merged commit 262aea1 into Eventual-Inc:main Mar 7, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support arbitrary number of input columns for python UDF
3 participants