Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support arbitrary number of input columns for python UDF #1895

Closed
samster25 opened this issue Feb 17, 2024 · 0 comments · Fixed by #1984
Closed

Support arbitrary number of input columns for python UDF #1895

samster25 opened this issue Feb 17, 2024 · 0 comments · Fixed by #1984
Labels
p1 Important to tackle soon, but preemptable by p0

Comments

@samster25
Copy link
Member

samster25 commented Feb 17, 2024 •
edited
Loading

Our UDFs currently dont support variable number of inputs.

def __call__(self, *features: daft.Series) -> pd.Series:

However there isn't a reason that we can't support this!

I believe the fault is in our inspect / bind code when creating UDFs.
@jaychia jaychia added p1 Important to tackle soon, but preemptable by p0 p0 Priority 0 - to be addressed immediately and removed p1 Important to tackle soon, but preemptable by p0 p0 Priority 0 - to be addressed immediately labels Feb 20, 2024
@samster25 samster25 linked a pull request Mar 6, 2024 that will close this issue
[FEAT] Enable UDF to handle arbitrary number of Daft series #1984
Merged
@samster25 samster25 mentioned this issue Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p1 Important to tackle soon, but preemptable by p0
Projects
Daft-OSS
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEAT] Enable UDF to handle arbitrary number of Daft series gmweaver/Daft
2 participants
@samster25 @jaychia