Represent big integers as arrays of bytes #87
+52
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moritz Barsnick <[email protected]>
Signed-off-by: Moritz Barsnick <[email protected]>
…tet array Signed-off-by: Moritz Barsnick <[email protected]>
…tet array Signed-off-by: Moritz Barsnick <[email protected]>
For code readability. Signed-off-by: Moritz Barsnick <[email protected]>
When adding the final byte or octet, skip it when its value is zero. Trailing 0-octets are meaningless in both cases and shouldn't be provided. Signed-off-by: Moritz Barsnick <[email protected]>
Found by review, confirmed by cppcheck. Also reorder the code lines to a more logical order. Signed-off-by: Moritz Barsnick <[email protected]>
Signed-off-by: Moritz Barsnick <[email protected]>
Signed-off-by: Moritz Barsnick <[email protected]>
|
Missing:
|
barsnick
changed the title
SebaLukas
approved these changes
Oct 24, 2024
| } | ||
| if (dummy_count > 0) { | ||
| *(current_octet-1) |= EXI_BASETYPES_OCTET_SEQ_FLAG_MASK; | ||
| if (dummy_count > 0 && dummy != 0) { |
There was a problem hiding this comment.
Is dummy != 0 here necessary?
It's relevant, I just read dummy_count twice...
|
libcbv2g with the generated code builds without problems. Unit tests passed and EVerest SIL work as well. So happy to merge this one 👍 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In PR #65, support for proper coding of large integer (xs:integer) was added, aiding in the proper handling of X509SerialNumber.
Yet the API presented those numbers in the same style as EXI internally, i.e. with 8/7 padding, adding an indicator MSB to each octet for understanding whether the sequence continues.
This change now expects those numbers as arrays of bytes (still within an
exi_unsigned_t), representing the integer, without any padding. The byte order is big-endian, i.e. leading bytes in the array have the most significant meaning.Issue ticket number and link
Relates to issue #54
Amends PR #65
Checklist before requesting a review