Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding big int support #18

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Adding big int support #18

merged 3 commits into from
Oct 25, 2024

Conversation

SebaLukas
Copy link
Collaborator

Describe your changes

Generated code from EVerest/cbexigen#87 to support BigInt encoding and decoding.

Issue ticket number and link

libcbv2g could not decode the CertificateInstalltionReq message. See this issue EVerest/cbexigen#54 for more details.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

Signed-off-by: Sebastian Lukas <[email protected]>
@corneliusclaussen corneliusclaussen marked this pull request as ready for review October 25, 2024 06:18
@hikinggrass
Copy link
Contributor

This should probably also bump the project version to something >0.2 (

VERSION 0.1
)

@barsnick
Copy link
Contributor

This should probably also bump the project version to something >0.2

I agree.

Also, the origin hash needs to be updated:
https://github.com/EVerest/libcbv2g/blob/feat/use_big_integer/CMakeLists.txt#L19

@barsnick
Copy link
Contributor

Okay for me if it works in your SILs. I have no regressions in my (66) ISO 15118-2 samples, but they don't include any big integer examples.

Please fix the CMakeLists.txt though.

@hikinggrass
Copy link
Contributor

Okay for me if it works in your SILs. I have no regressions in my (66) ISO 15118-2 samples, but they don't include any big integer examples.

Please fix the CMakeLists.txt though.

I've updated the hash (and added that it's from a unmerged branch) and bumped the version to 0.2.1, is that what you had in mind?

@barsnick
Copy link
Contributor

I've updated the hash (and added that it's from a unmerged branch) and bumped the version to 0.2.1, is that what you had in mind?

Exactly. Thanks!

@hikinggrass hikinggrass merged commit 0966194 into main Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants