Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop to a slightly less ancient version to allow us to use ruby-2.7 syntax #442

Merged
merged 44 commits into from
Jan 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
52546ab
Switch to theforeman-rubocop
adamruzicka Jan 25, 2024
37afd67
bundle exec rubocop --auto-gen-config
adamruzicka Jan 25, 2024
21246cc
Fix Lint/RedundantCop{Disable,Enable}Directive cops
adamruzicka Jan 25, 2024
7ed1927
Fix Style/MethodDefParentheses cop
adamruzicka Jan 25, 2024
25b62c5
Fix Naming/VariableName cop
adamruzicka Jan 25, 2024
f5ff4d2
Disable Style/LambdaCall cop
adamruzicka Jan 25, 2024
4882fbb
Pin bundler to 2.4.22
adamruzicka Jan 25, 2024
77622c1
Fix Layout/ArgumentAlignment cop
adamruzicka Jan 26, 2024
993ba8c
Fix Layout/EmptyLineAfterMagicComment cop
adamruzicka Jan 26, 2024
7ccf987
Fix Layout/EmptyLinesAroundClassBody cop
adamruzicka Jan 26, 2024
1f4ccb5
Fix Bundler/OrderedGems cop
adamruzicka Jan 29, 2024
ac0bdf1
Fix Gemspec/OrderedDependencies cop
adamruzicka Jan 29, 2024
d0fda74
Fix Gemspec/RequiredRubyVersion cop
adamruzicka Jan 29, 2024
063a540
Fix Layout/AssignmentIndentation cop
adamruzicka Jan 29, 2024
e5824e8
Fix Layout/ClosingHeredocIndentation cop
adamruzicka Jan 29, 2024
b59cf54
Fix Layout/EmptyLineBetweenDefs cop
adamruzicka Jan 29, 2024
c72f575
Fix Layout/EmptyLinesAroundAccessModifier cop
adamruzicka Jan 29, 2024
78f475b
Fix Layout/EmptyLinesAroundBlockBody cop
adamruzicka Jan 29, 2024
b515242
Fix Layout/EmptyLinesAroundMethodBody cop
adamruzicka Jan 29, 2024
6ac9e57
Fix Layout/EmptyLinesAroundModuleBody cop
adamruzicka Jan 29, 2024
54e5809
Fix Layout/EndAlignment cop
adamruzicka Jan 29, 2024
d34fed2
Fix Layout/ExtraSpacing cop
adamruzicka Jan 29, 2024
509f2c6
Fix Layout/EmptyLinesAroundExceptionHandlingKeywords cop
adamruzicka Jan 29, 2024
2ba63a8
Fix Layout/DotPosition cop
adamruzicka Jan 29, 2024
be0238f
Fix Layout/HeredocIndentation cop
adamruzicka Jan 29, 2024
f57e28f
Fix Layout/LeadingEmptyLines cop
adamruzicka Jan 29, 2024
fd41705
Fix Layout/MultilineMethodCallBraceLayout, Layout/MultilineMethodCall…
adamruzicka Jan 29, 2024
37dabb1
Fix Layout/SpaceAroundOperators cop
adamruzicka Jan 29, 2024
f693867
Fix Layout/SpaceBeforeComma cop
adamruzicka Jan 29, 2024
ecc04ee
Fix Layout/SpaceInLambdaLiteral cop
adamruzicka Jan 29, 2024
8faa2cb
Fix Layout/SpaceInsideBlockBraces cop
adamruzicka Jan 29, 2024
b54424c
Fix Layout/SpaceInsideHashLiteralBraces cop
adamruzicka Jan 29, 2024
859542f
Fix Layout/SpaceInsideParens cop
adamruzicka Jan 29, 2024
4ed4368
Fix Layout/SpaceInsideStringInterpolation cop
adamruzicka Jan 29, 2024
d08abec
Fix Layout/TrailingEmptyLines cop
adamruzicka Jan 29, 2024
85a9677
Fix Lint/AmbiguousBlockAssociation cop
adamruzicka Jan 29, 2024
cb6e7e4
Fix Lint/AmbiguousOperator cop
adamruzicka Jan 29, 2024
b1ac92d
Fix Lint/AmbiguousRegexpLiteral cop
adamruzicka Jan 29, 2024
4a3895e
Fix Lint/DisjunctiveAssignmentInConstructor cop
adamruzicka Jan 29, 2024
39f574f
Fix Lint/EmptyWhen cop
adamruzicka Jan 29, 2024
cff23af
Fix Lint/ParenthesesAsGroupedExpression cop
adamruzicka Jan 29, 2024
c328c0a
Fix Lint/RedundantCopDisableDirective cop
adamruzicka Jan 29, 2024
07ee874
Fix Lint/RedundantRequireStatement cop
adamruzicka Jan 29, 2024
1639598
Fix Lint/SendWithMixinArgument cop
adamruzicka Jan 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
ruby-version: 2.7
- name: Setup
run: |
gem install bundler -v 2.4.22
gem install bundler --version=2.4.22
bundle install --jobs=3 --retry=3
- name: Run rubocop
run: bundle exec rubocop
Expand Down
16 changes: 11 additions & 5 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,29 +1,35 @@
inherit_from: .rubocop_todo.yml
inherit_gem:
theforeman-rubocop:
- lenient.yml

AllCops:
TargetRubyVersion: 2.3
TargetRubyVersion: 2.7

# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
Style/ExtraSpacing:
Layout/ExtraSpacing:
Enabled: true

# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: with_first_parameter, with_fixed_indentation
Style/AlignParameters:
Layout/ParameterAlignment:
Enabled: true

# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: aligned, indented
Style/MultilineOperationIndentation:
Layout/MultilineOperationIndentation:
Enabled: true

# Cop supports --auto-correct.
Style/EmptyLines:
Layout/EmptyLines:
Enabled: true

Metrics/ModuleLength:
Exclude:
- test/**/*

Style/LambdaCall:
Enabled: false
Loading
Loading