Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Sensor Util Functions #130

Merged

Conversation

amystamile-usgs
Copy link
Contributor

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link
Contributor

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a good translation of the functions from the SensorUtils library into knoten. A lot of my concerns are how coupled we want to make this with CSM and the amount of work that may be necessary to replicate some of the functionality in ISIS. Mainly getting Illumination "stuff" into knoten for use.

The other issue is shapemodels. If PSMRTS is ready for use relatively soon I see this as a none issue. If that's not the case or we decide not to adopt it, we will have to home roll a fair amount of shapemodel stuff.

There is some deviation from the function signatures w.r.t. shapemodel. I think providing a shape argument and a very barebones ellipsoid model would be enough

knoten/sensor_utils.py Show resolved Hide resolved
knoten/sensor_utils.py Outdated Show resolved Hide resolved
knoten/sensor_utils.py Outdated Show resolved Hide resolved
knoten/sensor_utils.py Show resolved Hide resolved
knoten/csm.py Show resolved Hide resolved
knoten/csm.py Outdated Show resolved Hide resolved
@amystamile-usgs
Copy link
Contributor Author

@acpaquette I believe I made all the changes you suggested. Let me know if I went the right direction with this. If so, I will work on fixing the tests and docs.

Copy link
Contributor

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! One small thing to address but feel free to update tests

knoten/shape.py Outdated Show resolved Hide resolved
@amystamile-usgs amystamile-usgs merged commit 8600370 into DOI-USGS:main May 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants