Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVENT-843 - FedCM Beta Testing #849

Merged
merged 1 commit into from
Dec 14, 2023
Merged

EVENT-843 - FedCM Beta Testing #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/.htaccess
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ AddDefaultCharset utf-8
# see the specification: http://w3.org/TR/CSP).

# <IfModule mod_headers.c>
# Header set Content-Security-Policy "script-src 'self'; object-src 'self'"
# Header set Content-Security-Policy "script-src 'self' https://accounts.google.com/gsi/client; object-src 'self'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change do anything? Isn't this entire line just a comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it doesn't do anything. But if the CSP ever gets used, it will need to be there.

# <FilesMatch "\.(appcache|crx|css|eot|gif|htc|ico|jpe?g|js|m4a|m4v|manifest|mp4|oex|oga|ogg|ogv|otf|pdf|png|safariextz|svg|svgz|ttf|vcf|webapp|webm|webp|woff|xml|xpi)$">
# Header unset Content-Security-Policy
# </FilesMatch>
Expand Down
1 change: 1 addition & 0 deletions app/scripts/components/GoogleLogin/GoogleLogin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ const GoogleLogin = ({ $http, $document, envService }: GoogleLoginProps) => {
<>
<div
id="g_id_onload"
data-use_fedcm_for_prompt="true"
data-client_id={clientId}
data-auto_prompt="true"
data-nonce={googleNonce}
Expand Down
Loading