EVENT-843 - FedCM Beta Testing #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleballdrin
added
the
On Staging
canac
reviewed
Dec 12, 2023
| @@ -278,7 +278,7 @@ AddDefaultCharset utf-8 | |||
| # see the specification: http://w3.org/TR/CSP). | |||
|
|
|||
| # <IfModule mod_headers.c> | |||
| # Header set Content-Security-Policy "script-src 'self'; object-src 'self'" | |||
| # Header set Content-Security-Policy "script-src 'self' https://accounts.google.com/gsi/client; object-src 'self'" | |||
There was a problem hiding this comment.
Does this change do anything? Isn't this entire line just a comment?
There was a problem hiding this comment.
I guess it doesn't do anything. But if the CSP ever gets used, it will need to be there.
canac
approved these changes
Dec 12, 2023
wrandall22
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://jira.cru.org/browse/EVENT-843
Google login is changing and we need to be ready for it, we should hop on the FedCM beta to make sure this move won't break ERT's ability to login via Google.
https://developers.googleblog.com/2023/08/announcing-federated-credential-management-beta-for-gis.html
Changes I made
I followed these steps: https://developers.google.com/identity/gsi/web/guides/fedcm-migration