Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release actions for dApp examples #70

Merged
merged 14 commits into from
Apr 11, 2024
Merged

Add release actions for dApp examples #70

merged 14 commits into from
Apr 11, 2024

Conversation

lassemoldrup
Copy link
Contributor

@lassemoldrup lassemoldrup commented Mar 26, 2024

Purpose

Closes #69.

Closes #78

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@lassemoldrup lassemoldrup requested a review from DOBEN April 5, 2024 13:27
Copy link
Member

@DOBEN DOBEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a research question and can be done in a different PR/issue:

Currently, if someone accidentally wrongly tags this repo e.g. euroe-demo/0.0.0, this release pipeline is triggered. The release pipeline would look up the correct version and publish it to docker hub. Nonetheless, to not rely on the reviewer/approver of the release pipeline to check for a version mismatch, it would be nice if the release action could check (when it was triggered via a tag) that the versions match.

@abizjak
Copy link
Contributor

abizjak commented Apr 9, 2024

This is a research question and can be done in a different PR/issue:

Currently, if someone accidentally wrongly tags this repo e.g. euroe-demo/0.0.0, this release pipeline is triggered. The release pipeline would look up the correct version and publish it to docker hub. Nonetheless, to not rely on the reviewer/approver of the release pipeline to check for a version mismatch, it would be nice if the release action could check (when it was triggered via a tag) that the versions match.

Yes, this is correct, but it's also one of those things where having this check adds extra complexity and problems. So I don't think this is really necessary for now. It's a nice to have that we can live without.

@DOBEN
Copy link
Member

DOBEN commented Apr 9, 2024

This is a research question and can be done in a different PR/issue:
Currently, if someone accidentally wrongly tags this repo e.g. euroe-demo/0.0.0, this release pipeline is triggered. The release pipeline would look up the correct version and publish it to docker hub. Nonetheless, to not rely on the reviewer/approver of the release pipeline to check for a version mismatch, it would be nice if the release action could check (when it was triggered via a tag) that the versions match.

Yes, this is correct, but it's also one of those things where having this check adds extra complexity and problems. So I don't think this is really necessary for now. It's a nice to have that we can live without.

We can create an issue for future research in the backlog.
#78

@DOBEN DOBEN self-requested a review April 9, 2024 08:45
@abizjak abizjak temporarily deployed to testnet-deployments April 11, 2024 11:28 — with GitHub Actions Inactive
@abizjak abizjak temporarily deployed to testnet-deployments April 11, 2024 12:28 — with GitHub Actions Inactive
@abizjak abizjak temporarily deployed to testnet-deployments April 11, 2024 12:30 — with GitHub Actions Inactive
@abizjak abizjak merged commit 4058f8d into main Apr 11, 2024
57 checks passed
@abizjak abizjak deleted the release-actions branch April 11, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for version mismatch in docker release pipelines Add Github actions release jobs
3 participants