Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the CLICKHOUSE_CPP_ prefix for all cmake build options. #360

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Added the CLICKHOUSE_CPP_ prefix for all cmake build options. #360

merged 2 commits into from
Feb 20, 2024

Conversation

german3w1
Copy link
Contributor

For version 3.0

Enmk
Enmk requested changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change base branch from master to 3.0 ?

@german3w1 german3w1 marked this pull request as draft February 15, 2024 20:58
@german3w1 german3w1 changed the base branch from master to 3.0 February 15, 2024 20:58
@german3w1 german3w1 marked this pull request as ready for review February 15, 2024 21:00
@german3w1
Copy link
Contributor Author

image
Is that enough?)

Enmk
Enmk approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Enmk Enmk merged commit db36d10 into ClickHouse:3.0 Feb 20, 2024
16 checks passed
@Enmk Enmk mentioned this pull request Feb 28, 2024
Closed
@german3w1 german3w1 deleted the build_options_prefix branch February 28, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enmk Enmk Enmk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@german3w1 @Enmk