Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe add prefix for all defined cmake build options? #358

Closed
german3w1 opened this issue Feb 7, 2024 · 2 comments
Closed

Maybe add prefix for all defined cmake build options? #358

german3w1 opened this issue Feb 7, 2024 · 2 comments
Labels
3.0 Features planned for 3.0

Comments

@german3w1
Copy link
Contributor

german3w1 commented Feb 7, 2024

Hi, @Enmk!.
I noticed that all the build options in the root CMakeLists.txt do not have any prefixes to ensure that they do not overlap with other project options when included as a dependency.
How about sacrificing a little backwards compatibility and adding the prefix CLICKHOUSE_CPP_ to the name of each option (in the YAML_CPP library its authors went exactly this way, for example)

Example for clickhouse: BUILD_TESTS -> CLICKHOUSE_CPP_BUILD_TESTS

I'll do this if you find the idea is worth

@Enmk Enmk added the 3.0 Features planned for 3.0 label Feb 12, 2024
@Enmk
Copy link
Collaborator

Enmk commented Feb 12, 2024

Sure, let's do it! I think that this might be a good idea for a 3.0 release.

@Enmk
Copy link
Collaborator

Enmk commented Feb 28, 2024

Fixed in #360

@Enmk Enmk closed this as completed Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 Features planned for 3.0
Projects
None yet
Development

No branches or pull requests

2 participants