You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, @Enmk!.
I noticed that all the build options in the root CMakeLists.txt do not have any prefixes to ensure that they do not overlap with other project options when included as a dependency.
How about sacrificing a little backwards compatibility and adding the prefix CLICKHOUSE_CPP_ to the name of each option (in the YAML_CPP library its authors went exactly this way, for example)
Example for clickhouse: BUILD_TESTS -> CLICKHOUSE_CPP_BUILD_TESTS
I'll do this if you find the idea is worth
The text was updated successfully, but these errors were encountered:
Hi, @Enmk!.
I noticed that all the build options in the root
CMakeLists.txt
do not have any prefixes to ensure that they do not overlap with other project options when included as a dependency.How about sacrificing a little backwards compatibility and adding the prefix
CLICKHOUSE_CPP_
to the name of each option (in theYAML_CPP
library its authors went exactly this way, for example)Example for clickhouse:
BUILD_TESTS
->CLICKHOUSE_CPP_BUILD_TESTS
I'll do this if you find the idea is worth
The text was updated successfully, but these errors were encountered: