Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Franca translation using alternative Translation method using table-driven approach #130

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Draft: Franca translation using alternative Translation method using table-driven approach #130

wants to merge 6 commits into from

Commits on Oct 22, 2024

  1. Use modern installation method (containers and CI tests) 

    Installation of the local package for development testing has changed,
because calling setup.py directly is now deprecated (see multiple
sources in python community for more details)

Signed-off-by: Gunnar Andersson <[email protected]>
    @gunnar-mb
    gunnar-mb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    8f7e343 View commit details
    Browse the repository at this point in the history

  2. Bugfix: arraysize on Error shall be int, had wrong type 

    We might consider some type of consolidation to define identical
concepts in one place - for example many items need a datatype
definition.  But, comparing to Error to Argument, for example, one
difference is that the Error item is optionally named but Arguments must
be named.
    @gunnar-mb
    gunnar-mb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    b634a1e View commit details
    Browse the repository at this point in the history

  3. Update pyfranca submodule

    @gunnar-mb
    gunnar-mb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    9e41d1c View commit details
    Browse the repository at this point in the history

  4. Franca2IFEX and new table-driven translation approach 

    Signed-off-by: Gunnar Andersson <[email protected]>
    @gunnar-mb
    gunnar-mb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    25f937e View commit details
    Browse the repository at this point in the history

  5. rule_translator: Reverse if-logic and other refactorings 

    The transform function is complex to understand and the deep nesting of
for-loops and if-statements doesn't help.  Reversing the if-statement
logic for special cases allows us to leave or continue the loop early,
and reduces nesting for the happy-path case.  This simplifies reading
the code I think.

Signed-off-by: Gunnar Andersson <[email protected]>
    @gunnar-mb
    gunnar-mb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    4561b79 View commit details
    Browse the repository at this point in the history

  6. rule_translator: Cleanup and comments 

    Signed-off-by: Gunnar Andersson <[email protected]>
    @gunnar-mb
    gunnar-mb committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    ae6a17e View commit details
    Browse the repository at this point in the history