Draft: Franca translation using alternative Translation method using table-driven approach #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunnar-mb
force-pushed
the
table_driven_approach
branch
9 times, most recently
from
9d30b36
to
e8a66c0
Compare
gunnar-mb
force-pushed
the
table_driven_approach
branch
from
e8a66c0
to
eae6902
Compare
Installation of the local package for development testing has changed, because calling setup.py directly is now deprecated (see multiple sources in python community for more details) Signed-off-by: Gunnar Andersson <[email protected]>
We might consider some type of consolidation to define identical concepts in one place - for example many items need a datatype definition. But, comparing to Error to Argument, for example, one difference is that the Error item is optionally named but Arguments must be named.
Signed-off-by: Gunnar Andersson <[email protected]>
The transform function is complex to understand and the deep nesting of for-loops and if-statements doesn't help. Reversing the if-statement logic for special cases allows us to leave or continue the loop early, and reduces nesting for the happy-path case. This simplifies reading the code I think. Signed-off-by: Gunnar Andersson <[email protected]>
Signed-off-by: Gunnar Andersson <[email protected]>
gunnar-mb
force-pushed
the
table_driven_approach
branch
from
eae6902
to
ae6a17e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author: Gunnar Andersson <[email protected]>, MBition GmbH.
DRAFT for comments - table-driven translation approach (Franca)
The program was tested solely for our own use cases, which might differ from yours.
The submission is provided under the main project license (LICENSE file in root of project).
Provider Information