-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding RISC-V Vector support for CHERIoT #58
base: main
Are you sure you want to change the base?
Conversation
If I'm not mistaken this adds the vanilla vector extension to CHERIoT Sail. How do we deal with vectorized memory addresses? Is it worth describing the interaction between CHERIoT and the V extension in the ISA document before changing the Sail? |
If you look at, for instance, this, it uses the function |
Yes, the memory checks should just work if they follow the conventions of the existing RISC-V memory access instructions. We do need to think about the CSRs though. They probably need to be added to the allow list. |
Good point. I overlooked that. Let me see if that can be fixed. |
Where is the allow list? https://github.com/CHERIoT-Platform/sail-riscv/blob/cf541bea6be2d612c9bc91af032ab277a3756512/model/riscv_csr_map.sail#L171-L177 seems to be uncommented. |
This one for code running without access system regs perm: https://github.com/microsoft/cheriot-sail/blob/09ef3a7daad39293596e06dcf9079194b47f3e8c/src/cheri_addr_checks.sail#L229 |
Fixed. Thanks! |
Companion to CHERIoT-Platform/sail-riscv#2