Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding RISC-V Vector support for CHERIoT #58

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vmurali
Copy link
Contributor

@vmurali vmurali commented Jul 10, 2024

@vmurali
Copy link
Contributor Author

vmurali commented Jul 10, 2024

@rmn30 @nwf-msr

@marnovandermaas
Copy link
Contributor

If I'm not mistaken this adds the vanilla vector extension to CHERIoT Sail. How do we deal with vectorized memory addresses? Is it worth describing the interaction between CHERIoT and the V extension in the ISA document before changing the Sail?

@vmurali
Copy link
Contributor Author

vmurali commented Jul 11, 2024

If you look at, for instance, this, it uses the function ext_data_get_addr that is effectively overwritten in cheriot-sail. So everything works immediately.

@rmn30
Copy link
Collaborator

rmn30 commented Jul 11, 2024

Yes, the memory checks should just work if they follow the conventions of the existing RISC-V memory access instructions. We do need to think about the CSRs though. They probably need to be added to the allow list.

@vmurali
Copy link
Contributor Author

vmurali commented Jul 11, 2024

Good point. I overlooked that. Let me see if that can be fixed.

@vmurali
Copy link
Contributor Author

vmurali commented Jul 11, 2024

@rmn30
Copy link
Collaborator

rmn30 commented Jul 11, 2024

@vmurali
Copy link
Contributor Author

vmurali commented Jul 11, 2024

This one for code running without access system regs perm:

https://github.com/microsoft/cheriot-sail/blob/09ef3a7daad39293596e06dcf9079194b47f3e8c/src/cheri_addr_checks.sail#L229

Fixed. Thanks!

@vmurali vmurali changed the title Adding RISC-V Vector support for CHERIoT (no floating point support) Adding RISC-V Vector support for CHERIoT Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants