Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range checks cable parameters #287

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Range checks cable parameters #287

merged 2 commits into from
Jul 2, 2024

Commits on Jul 2, 2024

  1. Flags for range checks in CABLE vars (#225) 

    Fixes #225

Add 2 flags to range checks

```
check%ranges (0, 1, 2) - When to do the range checks NO_CHECK, ON_TIMESTEP, ON_WRITE
check%exit (.true., .false.) - Whether to exit the program if range checks are done, and out of range - the other option is to provide a warning
```

- Checks are being done in the following stages
   1. Parameters of `soil` and `veg` before running the spinloop
   2. Parameters when creating the NetCDF output file (some of them clash with `soil` and `veg` but code can be refactored in the future to account for that)
   3. Landuse variables I/O
   4. Variables in creating restart file
   5. Variables at every timestep
- Redesign `cable_output` with introducing `generate_out_write_acc`, and `check_and_write`
- Change the range checks to be done in `cable_write` during `cable_output`.
- Make `output_inclusion_type` dependencies clear between group output and individual values

Tested with experiments in `bench_example` for `main` vs current commit.

<!-- readthedocs-preview cable start -->
----
📚 Documentation preview 📚: https://cable--287.org.readthedocs.build/en/287/

<!-- readthedocs-preview cable end -->
    @abhaasgoyal
    abhaasgoyal committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    e273737 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into 225-range-checks-cabl… 

    …e-params
    @abhaasgoyal
    abhaasgoyal committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    3084239 View commit details
    Browse the repository at this point in the history