Range checks cable parameters #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhaasgoyal
changed the title
ccarouge
reviewed
Jun 19, 2024
ccarouge
reviewed
Jun 19, 2024
ccarouge
reviewed
Jun 19, 2024
ccarouge
reviewed
Jun 19, 2024
ccarouge
reviewed
Jun 19, 2024
abhaasgoyal
commented
Jun 19, 2024
|
@abhaasgoyal I'm not sure what happened but for some reason, some comments got posted before I finished the review.. I'm still working on it but I'm getting to the end. |
ccarouge
requested changes
Jun 20, 2024
ccarouge
requested changes
Jun 20, 2024
|
After reviewing this, I think we should have split this work into 3:
But I guess it's easier to see with the final version than at the start. I'm just mentioning it as something to try and learn from for later work. |
ccarouge
requested changes
Jun 25, 2024
|
Note: Before merging, I'll squash the commits into one with message and appropriate description |
|
@abhaasgoyal actually don't merge! I'm missing the info on what tests have been run after review. |
abhaasgoyal
force-pushed
the
225-range-checks-cable-params
branch
from
fcbab92
to
0e8df87
Compare
|
Tested using custom-build in
The output comparisons differ in defining headers for # Tail outputs file names along with the contents
tail -n +1 * | sed -n '/Failed to find variable RootResp/!p' | sed -n '/Failed to find variable StemResp/!p' | tee tempThere seem to be no differences in some tests (like The errors seem to be showing the following template: Update: When run with The variables are out of range in the range of -10%-70%. The best I could suspect is that in |
abhaasgoyal
commented
Jun 27, 2024
abhaasgoyal
commented
Jun 28, 2024
|
Tested with the following configurations:
Then Status As of now, the bitwise comparisons of the output files pass in all configs. Output (provided only for case 1, case 2 and 3 were the same |
|
@abhaasgoyal Good to go! 🎉 |
Fixes #225 Add 2 flags to range checks ``` check%ranges (0, 1, 2) - When to do the range checks NO_CHECK, ON_TIMESTEP, ON_WRITE check%exit (.true., .false.) - Whether to exit the program if range checks are done, and out of range - the other option is to provide a warning ``` - Checks are being done in the following stages 1. Parameters of `soil` and `veg` before running the spinloop 2. Parameters when creating the NetCDF output file (some of them clash with `soil` and `veg` but code can be refactored in the future to account for that) 3. Landuse variables I/O 4. Variables in creating restart file 5. Variables at every timestep - Redesign `cable_output` with introducing `generate_out_write_acc`, and `check_and_write` - Change the range checks to be done in `cable_write` during `cable_output`. - Make `output_inclusion_type` dependencies clear between group output and individual values Tested with experiments in `bench_example` for `main` vs current commit. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--287.org.readthedocs.build/en/287/ <!-- readthedocs-preview cable end -->
abhaasgoyal
force-pushed
the
225-range-checks-cable-params
branch
from
8552247
to
3084239
Compare
This was referenced Jul 15, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CABLE
Description
Fixes #225
Add 2 flags to range checks
soilandvegbefore running the spinloopsoilandvegbut code can be refactored in the future to account for that)cable_outputwith introducinggenerate_out_write_acc, andcheck_and_writecable_writeduringcable_output.output_inclusion_typedependencies clear between group output and individual valuesTested with experiments in
bench_exampleformainvs current commit.📚 Documentation preview 📚: https://cable--287.org.readthedocs.build/en/287/