Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testcase from Uber Quick guide. #286

Conversation

ccarouge
Copy link
Collaborator

@ccarouge ccarouge commented May 7, 2024

CABLE

Thank you for submitting a pull request to the CABLE Project.

Description

Fixes #(285)
Change Uber Quick guide instructions to run the testcase from src/offline/ since for now CABLE needs the namelists in the run directory.

Type of change

Please delete options that are not relevant.

  • New or updated documentation

Checklist

  • The new content is accessible and located in the appropriate section.
  • I have checked that links are valid and point to the intended content.
  • I have checked my code/text and corrected any misspellings

Please add a reviewer when ready for review.


📚 Documentation preview 📚: https://cable--286.org.readthedocs.build/en/286/

@ccarouge ccarouge force-pushed the 285-uber-quick-guide-bug-the-test-simulation-does-not-run-according-to-instructions branch from 4972e95 to 81b8795 Compare May 7, 2024 06:12
@ccarouge ccarouge requested a review from SeanBryan51 May 7, 2024 06:27
@ccarouge
Copy link
Collaborator Author

ccarouge commented May 7, 2024

I have checked that running the cable executable from within src/offline/ is successful at running the testcase

Copy link
Collaborator

@SeanBryan51 SeanBryan51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so we have a working example in the docs, but I'm not really a fan of having the inputs mixed up with source files or running the model in the src/offline directory as log files and such will be dumped into the repo.

@ccarouge
Copy link
Collaborator Author

ccarouge commented May 7, 2024

I'm not really a fan of having the inputs mixed up with source files or running the model in the src/offline directory

Totally agree but we need to work with what we currently have and improve as we go.

@ccarouge ccarouge merged commit 45d1497 into main May 7, 2024
3 checks passed
@ccarouge ccarouge deleted the 285-uber-quick-guide-bug-the-test-simulation-does-not-run-according-to-instructions branch May 7, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uber quick guide bug: the test simulation does not run according to instructions
2 participants