Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmodl, sympy: bump sympy version #2508

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

nmodl, sympy: bump sympy version #2508

wants to merge 3 commits into from

Conversation

JCGoran
Copy link

@JCGoran JCGoran commented Sep 2, 2024

No description provided.

@bbpbuildbot
Copy link
Collaborator

Thank you for your pull request!

Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running.

@JCGoran JCGoran changed the title nmodl: bump sympy version nmodl, sympy: bump sympy version Sep 2, 2024
@@ -11,6 +11,7 @@ class PySympy(PythonPackage):

pypi = "sympy/sympy-0.7.6.tar.gz"

version("1.13.0", sha256="3b6af8f4d008b9a1a6a4268b335b984b23835f26d1d60b0526ebc71d48a25f57")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From upstream?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloaded the package from PyPI and did sha256sum sympy-1.13.0.tar.gz. The numbers for previous versions match this procedure, so I suppose that's the right thing to do?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easier: spack checksum <package>, and we should make sure that modifications to builtin packages make their way upstream. Otherwise, we're having a lot of fun with new deployments.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I open a PR upstream as well then (for sympy, that is)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be very nice! Maybe check the dependencies for updates (they will otherwise)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted upstream at: spack#46163

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding the dependencies from there here too?

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2508/config/modules.sh
module load unstable

Please test the following updated modules:

  • neurodamus-hippocampus/2.4.1
  • neurodamus-neocortex-plasticity/2.4.1
  • neurodamus-neocortex/2.4.1
  • neurodamus-thalamus/2.4.1
  • neuron/9.0.a17
  • psp-validation/0.6.0
  • py-atlinter/0.2.4
  • py-bbp-workflow/3.1.57
  • py-bluepyemodel/0.0.105
  • py-bluepyemodelnexus/0.0.8
  • py-bluepymm/0.8.7
  • py-bluepyopt/1.14.11
  • py-minis-validation/0.0.5
  • py-morph-tool/2.9.1
  • py-region-grower/1.4.0
  • py-synthesis-workflow/1.1.0
  • py-visual-cortex-analysis/0.2.3
  • python-dev/0.5

@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2508/config/modules.sh
module load unstable

Please test the following updated modules:

  • neurodamus-hippocampus/2.4.1
  • neurodamus-neocortex-plasticity/2.4.1
  • neurodamus-neocortex/2.4.1
  • neurodamus-thalamus/2.4.1
  • neuron/9.0.a17
  • psp-validation/0.6.0
  • py-atlinter/0.2.4
  • py-bbp-workflow/3.1.57
  • py-bluepyemodel/0.0.105
  • py-bluepyemodelnexus/0.0.8
  • py-bluepymm/0.8.7
  • py-bluepyopt/1.14.11
  • py-minis-validation/0.0.5
  • py-morph-tool/2.9.1
  • py-region-grower/1.4.0
  • py-synthesis-workflow/1.1.0
  • py-visual-cortex-analysis/0.2.3
  • python-dev/0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants