Set strict mode for sympy #1418
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise a proper Python error instead of the mysterious parser error about an unexpexted `/`. The full code is actually: /* Not supported in C */ /* <list of symbols/functions> */ Only works in Sympy 1.13 and above.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Aug 30, 2024
This comment has been minimized.
This comment has been minimized.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Sep 2, 2024
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Sep 2, 2024
This comment has been minimized.
This comment has been minimized.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Sep 2, 2024
|
Logfiles from GitLab pipeline #229385 (:white_check_mark:) have been uploaded here! Status and direct links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1129 (or at least it shows a readable error this time).
Raise a proper Python error instead of the mysterious parser error about an unexpexted
/.The full error is actually caused by:
being part of the output, and NMODL cannot handle it.
Only works in Sympy 1.13 and above, so SymPy has also been bumped.
Needs BlueBrain/spack#2508.