Clean up wheel contents. #144

matz-e · 2024-03-19T15:15:25Z

Fixes #143. Replaces setuptools, which seems very happy to just add
everything in the current directory into the source distribution with
hatch, which is much, much, much more reasonable. Also:

Delete now obsolete MANIFEST.in
Delete outdated, non-functional _debug.py
Move init.py, core/hoc, core/mod into neurodamus/data to properly compartmentalize it

WeinaJi · 2024-03-21T13:27:24Z

Thanks for the improvements. I've learned new things about hatching.
Just a question: I ran hatch version on a local checkout of tag 3.1.1 and the version returned is 3.1.2.dev0 instead of 3.1.1 . Will we get the same kind of version on the wheel generated at new tags?

matz-e · 2024-03-21T15:27:20Z

Thanks for the improvements. I've learned new things about hatching. Just a question: I ran hatch version on a local checkout of tag 3.1.1 and the version returned is 3.1.2.dev0 instead of 3.1.1 . Will we get the same kind of version on the wheel generated at new tags?

Hm, it should. If I checkout this PR, run git tag 123 and then hatchling version, I get the expected output of 123. Do you have steps I can reproduce?

WeinaJi · 2024-03-22T08:14:10Z

Thanks for the improvements. I've learned new things about hatching. Just a question: I ran hatch version on a local checkout of tag 3.1.1 and the version returned is 3.1.2.dev0 instead of 3.1.1 . Will we get the same kind of version on the wheel generated at new tags?

Hm, it should. If I checkout this PR, run git tag 123 and then hatchling version, I get the expected output of 123. Do you have steps I can reproduce?

Ah yes, you are right. In fact, I made a change in my local check out of the tag, that's why I got dev0. The versioning is ok.

WeinaJi · 2024-03-22T08:23:35Z

I also tag @ferdonline @jorblancoa @atemerev here, to inform them of the new location of the hoc/mod folders and init.py file after this PR is merged.

Fixes #143. Replaces `setuptools`, which seems very happy to just add everything in the current directory into the source distribution with `hatch`, which is much, much, much more reasonable. Also: * Delete now obsolete `MANIFEST.in` * Delete outdated, non-functional `_debug.py` * Move `init.py` into `neurodamus/data` to properly compartmentalize it

bbpbuildbot · 2024-03-22T14:16:45Z

Logfiles from GitLab pipeline #201860 (:white_check_mark:) have been uploaded here!

Status and direct links:

Fixes #143. Replaces `setuptools`, which seems very happy to just add everything in the current directory into the source distribution with `hatch`, which is much, much, much more reasonable. Also: * Delete now obsolete `MANIFEST.in` * Delete outdated, non-functional `_debug.py` * Move `init.py`, `core/hoc`, `core/mod` into `neurodamus/data` to properly compartmentalize it