Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azcore] Add text [un]marshalling support to ResourceID #23381

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[azcore] Add text [un]marshalling support to ResourceID #23381

wants to merge 1 commit into from

Conversation

mbarnes
Copy link

@mbarnes mbarnes commented Aug 28, 2024

It would be handy for ResourceID to support the encoding.TextMarshaler and encoding.TextUnmarshaler interfaces so that, for example, JSON data that includes a resource ID string can be unmarshaled directly to a ResourceID struct (and vice versa for marshaling).

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to module CHANGELOG.md are included.
  • MIT license headers are included in each file.

@github-actions GitHub Actions
Copy link

Thank you for your contribution @mbarnes! We will review the pull request and get back to you soon.

@github-actions github-actions bot added Azure.Core Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Aug 28, 2024
mbarnes pushed a commit to Azure/ARO-HCP that referenced this pull request Aug 30, 2024
api: Add ResourceID wrapper type
1f7141b 
This is a thinly wrappered azcorearm.ResourceID that implements
the encoding.TextMarshaler and encoding.TextUnmarshaler interfaces,
so that ResourceID can be used directly in structs that get built
from JSON data.

I proposed this for azcorearm.ResourceID in:
Azure/azure-sdk-for-go#23381
@mbarnes mbarnes mentioned this pull request Aug 30, 2024
Merged
mjlshen pushed a commit to Azure/ARO-HCP that referenced this pull request Aug 30, 2024
@mjlshen
api: Add ResourceID wrapper type
a322e3b 
This is a thinly wrappered azcorearm.ResourceID that implements
the encoding.TextMarshaler and encoding.TextUnmarshaler interfaces,
so that ResourceID can be used directly in structs that get built
from JSON data.

I proposed this for azcorearm.ResourceID in:
Azure/azure-sdk-for-go#23381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner

@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT jhendrixMSFT is a code owner

@richardpark-msft richardpark-msft Awaiting requested review from richardpark-msft richardpark-msft is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Azure.Core Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mbarnes