Minor database API refactoring #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 30, 2024 09:47
The StringEquals function can do case-insensitive comparisons: https://learn.microsoft.com/en-us/azure/cosmos-db/nosql/query/stringequals This means resource IDs no longer have to be lowercased prior to reading from or writing to the Resources container.
This is a thinly wrappered azcorearm.ResourceID that implements the encoding.TextMarshaler and encoding.TextUnmarshaler interfaces, so that ResourceID can be used directly in structs that get built from JSON data. I proposed this for azcorearm.ResourceID in: Azure/azure-sdk-for-go#23381
mjlshen
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Use case-insensitive search for
ResourceDocumentThe StringEquals function can do case-insensitive comparisons. This means resource IDs no longer have to be lowercased prior to reading from or writing to the Resources container.
Add
ResourceIDwrapper typeThis is a thinly wrappered azcorearm.ResourceID that implements the encoding.TextMarshaler and encoding.TextUnmarshaler interfaces, so that
ResourceIDcan be used directly in structs that get built from JSON data.I proposed this for azcorearm.ResourceID in Azure/azure-sdk-for-go#23381. If accepted, we can eventually remove this wrapper type.