Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove "Configure NSG Flow Logs" deprecated recommendation + references #434

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: Remove "Configure NSG Flow Logs" deprecated recommendation + references #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2298219
Remove "Configure NSG Flow Logs" recommendation
jdmsoss Sep 25, 2024
fd14bed
Remove NSG flow logs recommendation references
jdmsoss Sep 25, 2024
d38b688
Add back recommendation in disabled state
oZakari Sep 30, 2024
d361d76
Merge pull request #1 from oZakari/pr/jdmsoss/434
jdmsoss Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion azure-resources/Network/applicationGateways/recommendations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
recommendationResourceType: Microsoft.Network/applicationGateways
recommendationMetadataState: Active
longDescription: |
Enable logging in storage accounts, Log Analytics, and monitoring services for auditing and insights. If using NSGs, enable NSG flow logs to be stored, providing in-depth traffic analysis into Azure Cloud.
Enable logging in storage accounts, Log Analytics, and monitoring services for auditing and insights.
potentialBenefits: Enhanced traffic insight and audit
pgVerified: true
publishedToLearn: false
Expand Down
1 change: 0 additions & 1 deletion azure-resources/Network/networkSecurityGroups/kql/da1a3c06-d1d5-a940-9a99-fcc05966fe7c.kql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,3 @@ resources
on $left.lowerCaseNsgId == $right.lowerCaseTargetNsgId
| where isempty(lowerCaseTargetNsgId)
| project recommendationId = "da1a3c06-d1d5-a940-9a99-fcc05966fe7c", name, id, tags, param1 = "NSGFlowLog: Not configured/Disabled"

2 changes: 1 addition & 1 deletion azure-resources/Network/networkSecurityGroups/recommendations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
recommendationControl: Monitoring and Alerting
recommendationImpact: Medium
recommendationResourceType: Microsoft.Network/networkSecurityGroups
recommendationMetadataState: Active
recommendationMetadataState: Disabled
longDescription: |
Monitoring, managing, and understanding your network is crucial for protection and optimization. Knowing the current state, who and from where connections are made, open internet ports, expected and irregular behavior, and traffic spikes is essential.
potentialBenefits: Enhances security and optimizes network
Expand Down
1 change: 0 additions & 1 deletion azure-specialized-workloads/avd/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ geekdocHidden: false
| [Connect on-prem networks to Azure critical workloads via multiple ExpressRoutes](../../../Azure-Proactive-Resiliency-Library-v2/azure-resources/Network/expressRouteCircuits/#connect-on-prem-networks-to-azure-critical-workloads-via-multiple-expressroutes) | Network | expressRouteCircuits |
| [Ensure ExpressRoute's physical links connect to distinct network edge devices](../../../Azure-Proactive-Resiliency-Library-v2/azure-resources/Network/expressRouteCircuits/#ensure-expressroutes-physical-links-connect-to-distinct-network-edge-devices) | Network | expressRouteCircuits |
| [Use Zone-redundant ExpressRoute gateway SKUs](../../../Azure-Proactive-Resiliency-Library-v2/azure-resources/Network/virtualNetworkGateways/#use-zone-redundant-expressroute-gateway-skus) | Network | virtualNetworkGateways |
| [Configure NSG Flow Logs](../../../Azure-Proactive-Resiliency-Library-v2/azure-resources/Network/networkSecurityGroups/#configure-nsg-flow-logs) | Network | networkSecurityGroups |
| [Ensure that storage accounts are zone or region redundant](../../../Azure-Proactive-Resiliency-Library-v2/azure-resources/Storage/storageAccounts/#ensure-that-storage-accounts-are-zone-or-region-redundant) | Storage | storageAccounts |
| [Enable Azure Private Link Service for Key vault](../../../Azure-Proactive-Resiliency-Library-v2/azure-resources/KeyVault/vaults/#enable-azure-private-link-service-for-key-vault) | Keyvault | vaults |
| [Configure Service Health Alerts](../../../Azure-Proactive-Resiliency-Library-v2/azure-resources/Insights/activityLogAlerts/#configure-service-health-alerts) | Insights | activityLogAlerts |
Expand Down
4 changes: 2 additions & 2 deletions tools/data/recommendations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1387,7 +1387,7 @@
"publishedToAdvisor": null,
"aprlGuid": "da1a3c06-d1d5-a940-9a99-fcc05966fe7c",
"recommendationTypeId": null,
"recommendationMetadataState": "Active",
"recommendationMetadataState": "Disabled",
"learnMoreLink": [
{
"url": "https://learn.microsoft.com/azure/network-watcher/network-watcher-nsg-flow-logging-overview",
Expand Down Expand Up @@ -2099,7 +2099,7 @@
}
],
"recommendationControl": "Monitoring and Alerting",
"longDescription": "Enable logging in storage accounts, Log Analytics, and monitoring services for auditing and insights. If using NSGs, enable NSG flow logs to be stored, providing in-depth traffic analysis into Azure Cloud.\n",
"longDescription": "Enable logging in storage accounts, Log Analytics, and monitoring services for auditing and insights.\n",
"pgVerified": true,
"description": "Monitor and Log the configurations and traffic",
"potentialBenefits": "Enhanced traffic insight and audit",
Expand Down
Loading