fix: Remove "Configure NSG Flow Logs" deprecated recommendation + references

[jdmsoss]

Overview/Summary

On 30 September 2027, NSG flow logs will be retired.

As part of this pull request I have

• Read the Contribution Guide and ensured this PR is compliant with the guide
• Checked for duplicate Pull Requests
• Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Ensured PR tests are passing
• Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
• Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

[ehaslett]

Do we have an official policy for APRL about when to remove guidance for services that are being retired? And how soon or not to remove the guidance? Currently I don't see a public announcement about the retirement.

That is:
Do we remove APRL guidance ASAP after retirement is announced? Or prior to the announcement?
Do we remove APRL guidance N days/months/years in advance of the retirement, but no sooner? (In this case it looks like 3 years)

[tksh164]

Currently I don't see a public announcement about the retirement.

The announcement was delivered via Health advisories in Service Health.

https://app.azure.com/h/4NBJ-DQ0/ebb993

[tksh164]

Retirement: Network security group flow logs in Azure Network Watcher will be retired
https://azure.microsoft.com/en-us/updates/v2/Azure-NSG-flow-logs-Retirement

[ehaslett]

Do we have an official policy for APRL about when to remove guidance for services that are being retired? And how soon or not to remove the guidance? Currently I don't see a public announcement about the retirement.

That is: Do we remove APRL guidance ASAP after retirement is announced? Or prior to the announcement? Do we remove APRL guidance N days/months/years in advance of the retirement, but no sooner? (In this case it looks like 3 years)

I recommend that as part of this change, new guidance under Virtual Networks be put in place for the configuration of Vnet flow logs.

[jdmsoss]

Do we have an official policy for APRL about when to remove guidance for services that are being retired? And how soon or not to remove the guidance? Currently I don't see a public announcement about the retirement.
That is: Do we remove APRL guidance ASAP after retirement is announced? Or prior to the announcement? Do we remove APRL guidance N days/months/years in advance of the retirement, but no sooner? (In this case it looks like 3 years)

I recommend that as part of this change, new guidance under Virtual Networks be put in place for the configuration of Vnet flow logs.

It already exists, but under Network Watcher component 👉 Enable NSG and Virtual Network Flow Logs

That's why I didn't suggest it, to avoid duplicates.

[oZakari]

@jdmsoss I created a PR against your branch to keep the recommendation in the repo in Disabled state so it won't show up in site or be added in WARA scripts until it is fully deprecated. That way, someone doesn't accidentally add it back in another PR.

cc: @ehaslett

[jdmsoss]

@jdmsoss I created a PR against your branch to keep the recommendation in the repo in Disabled state so it won't show up in site or be added in WARA scripts until it is fully deprecated. That way, someone doesn't accidentally add it back in another PR.

cc: @ehaslett

@oZakari I'm not sure to understand this one. If you submit back a PR on my forked repo main branch, won't that create a diff with the APRL upstream repo main branch?
Thanks for enlightening me on this practice or if you have any docs that correspond to this!

[oZakari]

Hey @jdmsoss, thanks for calling that out. I didn't realize I was targeting your main branch, so I corrected it to the nsg-flowlogs branch associated to this PR. Please review and merge if you can now.

[jdmsoss]

Hey @jdmsoss, thanks for calling that out. I didn't realize I was targeting your main branch, so I corrected it to the nsg-flowlogs branch associated to this PR. Please review and merge if you can now.

@oZakari Oh, right! It's clearer now I understand the issue ^^ PR merged on my side, thx 👍

[oZakari]

LGTM