use containers in GH actions (#580)

* use containers in GH actions * upd checkout action * Fix retrieving the branch name
AdguardTeam · Sep 19, 2024 · f792d7a · f792d7a
1 parent c697821
commit f792d7a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 19 deletions.
diff --git a/.github/workflows/build-deploy.yml b/.github/workflows/build-deploy.yml
@@ -1,7 +1,6 @@
 name: Build and deploy
 
 env:
-  NODE_VERSION: 20
   BASE_DOMAIN: kb-adg.pages.dev
   BASE_PATH: /
   PAGES_PROJECT: kb-adg
@@ -19,12 +18,10 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
+    container:
+      image: node:20
     steps:
-      - uses: actions/checkout@v3
-      - name: Setup Node.js
-        uses: actions/setup-node@v4
-        with:
-          node-version: ${{ env.NODE_VERSION }}
+      - uses: actions/checkout@v4
 
       - name: Setup pnpm
         uses: pnpm/action-setup@v4
@@ -37,9 +34,9 @@ jobs:
       - name: Determine branch for deploy
         id: get-branch
         run: |
-          if [ "${{ github.ref_name }}" == "master" ]; then
+          if [ "${{ github.ref_name }}" = "master" ]; then
             echo "BRANCH_NAME=main" >> $GITHUB_ENV
-          elif [ "${{ github.event_name }}" == "pull_request" ]; then
+          elif [ "${{ github.event_name }}" = "pull_request" ]; then
             PR_NUMBER=${{ github.event.number }}
             echo "BRANCH_NAME=pull-request-${PR_NUMBER}" >> $GITHUB_ENV
           else

diff --git a/.github/workflows/crowdin.yml b/.github/workflows/crowdin.yml
@@ -1,8 +1,5 @@
 name: Sync with Crowdin
 
-env:
-  NODE_VERSION: 20
-
 on:
   push:
     branches:
@@ -12,6 +9,8 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
+    container:
+      image: node:20
     steps:
       - uses: actions/checkout@v4
       - name: Setup Node.js

diff --git a/.github/workflows/markdown-lint.yml b/.github/workflows/markdown-lint.yml
@@ -1,8 +1,5 @@
 name: Lint Markdown
 
-env:
-  NODE_VERSION: 20
-
 on:
   push:
     branches:
@@ -13,12 +10,10 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
+    container:
+      image: node:20
     steps:
-      - uses: actions/checkout@v3
-      - name: Setup Node.js
-        uses: actions/setup-node@v4
-        with:
-          node-version: ${{ env.NODE_VERSION }}
+      - uses: actions/checkout@v4
 
       - name: Setup pnpm
         uses: pnpm/action-setup@v4