Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGS tip-tillt correction #98

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

GillesOrban
Copy link

This PR concerns the following:

  • Fix typos concerning LGS spot elongation
  • LGS image should not be flipped (line 400-402 in base.py). Can be seen in correlation map, e.g. for an on-axis launch the central slope variance should be minimum (if no obscuration, central slopes should be close to 0 for similar launch aperture and subaperture).
  • WIP: Correction of LGS tip-tilt is now possible using a combination of removeTT=True, correctLgsTT. At the moment this may not be fully realistic but helps to stabilize the LGS on a Shack-Hartmann. Comments are welcome.

@codecov-io
Copy link

Codecov Report

Merging #98 into master will decrease coverage by 0.17%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   66.93%   66.75%   -0.18%     
==========================================
  Files          24       24              
  Lines        3920     3950      +30     
==========================================
+ Hits         2624     2637      +13     
- Misses       1296     1313      +17
Impacted Files Coverage Δ
soapy/confParse.py 81.79% <100%> (+0.1%) ⬆️
soapy/wfs/base.py 62.75% <48.14%> (-4.5%) ⬇️
soapy/wfs/shackhartmann.py 86.51% <83.33%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e2b2e5...cae302d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants