Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for LGS uplink with ShackHartmann wfs #126

Merged
merged 2 commits into from
May 5, 2022

Conversation

ojdf
Copy link
Collaborator

@ojdf ojdf commented Apr 14, 2022

Fix for LGS uplink with using ShackHartmann wfs class. This fixes the backwards slopes issue when uplink=True, so the non-legacy version can be used. Also changed the example config file to use ShackHartmann instead of ShackHartmannLegacy.

I note that one of the changes (not flipping LGS psf) was also implemented in #98

@ojdf ojdf requested review from andrewpaulreeves and removed request for andrewpaulreeves April 14, 2022 13:45
@andrewpaulreeves
Copy link
Collaborator

Hi @ojdf - Was it a flip in the end? When we tried it out last time we found that it didnt' solve the issue. Or did we just flip at the wrong place? Either way - quick check before I merge - the LGS example now runs properly?

@ojdf
Copy link
Collaborator Author

ojdf commented Apr 25, 2022

@andrewpaulreeves yeah it was a flip, but in a different place. You had the flip on the LGS PSF before the convolution, which was correct but the subaps were still flipped so the slopes were backwards. What I've done is get rid of the flip before the convolution then apply it to the subaps after convolution with the LGS PSF. The LGS-uplink example now runs properly and I've changed the config file to use the non-legacy Shack Hartmann.

@andrewpaulreeves andrewpaulreeves merged commit 198d33e into AOtools:master May 5, 2022
@ojdf ojdf deleted the lgs_uplink_fix branch May 5, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants